Fix FaceFX Sequence TearDown on LevelSequencePlayer::PlayToFrame #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two FaceFX in sequence is playing and LevelSequencePlayer call PlayToFrame. This occurs sequence template TearDown called both of. First TearDown call TrackData.Empty() (TrackData is TMap container) at the END. Second TearDown will no idea to do anything which TrackData is already EMPTY. This commit is fix to remove from TrackData depend on current FaceFX Track Guid.
oliverzx
reviewed
May 6, 2020
|
It's my company's developing project which means I couldn't give the repo. Maybe I can take some screenshots of this issue for you tomorrow. |
|
|
cloud9370
commented
May 7, 2020
| @@ -155,6 +156,7 @@ void FFaceFXAnimationSectionTemplate::TearDown(FPersistentEvaluationData& Persis | |||
| return; | |||
There was a problem hiding this comment.
I found another problem while editing.
TrackId will not remove from TarckData on sequence edit due to function returned by key is nullptr.
There was a problem hiding this comment.
It caused by lost reference of Actor.
I opened level which actor in and play again, the Key is not nullptr
|
Is it possible to set up a sample scene using our sample content that will reproduce these issues? |
|
I will trying to reproduce this issue on simple project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two FaceFX in sequence is playing and LevelSequencePlayer call PlayToFrame.
This occurs sequence template TearDown called both of.
First TearDown call TrackData.Empty() (TrackData is TMap container) at the END.
Second TearDown will no idea to do anything which TrackData is already EMPTY.
This commit is fix to remove from TrackData depend on current FaceFX Track Guid.