Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add snowflakes #534

Merged
merged 2 commits into from
Jan 7, 2024
Merged

add snowflakes #534

merged 2 commits into from
Jan 7, 2024

Conversation

fcaps
Copy link
Collaborator

@fcaps fcaps commented Dec 30, 2023

closes #533

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8240d5) 41.17% compared to head (53d40b1) 41.17%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #534   +/-   ##
========================================
  Coverage    41.17%   41.17%           
========================================
  Files           71       71           
  Lines         1734     1734           
  Branches       210      210           
========================================
  Hits           714      714           
  Misses         988      988           
  Partials        32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcaps
Copy link
Collaborator Author

fcaps commented Dec 30, 2023

snow

@fcaps fcaps requested a review from Sheikah45 December 30, 2023 14:36
@Askaholic
Copy link
Contributor

Should it turn on/off automatically based on the date? That would probably be better than requiring a developer to merge a code change and have it get deployed each time.

@fcaps
Copy link
Collaborator Author

fcaps commented Dec 30, 2023

Should it turn on/off automatically based on the date? That would probably be better than requiring a developer to merge a code change and have it get deployed each time.

also thought about it, but then decided to keep it simple.
you can update this PR if you think this would be good to implement.

@Brutus5000 Brutus5000 merged commit 8daa828 into FAForever:develop Jan 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the wording of the rule regarding multiple accounts
3 participants