Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: BaseCarousel #297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: BaseCarousel #297

wants to merge 1 commit into from
+229 −0

Conversation

alemesa
Copy link
Member

@alemesa alemesa commented Aug 31, 2023

  • BaseCarousel

  • Usage

<BaseCarousel>
    <div>Slide 1</div>
    <div>Slide 2</div>
    <div>Slide 3</div>
</BaseCarousel>
  • Maybe it will be worth to implement Navigation, Pagination, ProgressBar, ScrollBar but thinking it might be bloated, usually we have simple carousel with some arrows (open to opinions)

@alemesa alemesa added the WIP label Aug 31, 2023
@alemesa alemesa changed the title feature: BaseCarousel feat: BaseCarousel Aug 31, 2023
@experiencemonks-devops
Copy link
Contributor

[AUTOMATED] Latest version has been pushed to preview.

Preview deployed at https://preview-8ecbaf0.dev.nextjs-boilerplate.jam3.cloud.jam3.net

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@experiencemonks-devops
Copy link
Contributor

[AUTOMATED] Latest version has been pushed to preview.

Preview deployed at https://preview-37a9115.dev.nextjs-boilerplate.jam3.cloud.jam3.net

edgardz
edgardz reviewed Sep 25, 2023
View reviewed changes
package.json
@@ -63,6 +63,7 @@
"react-dom": "18.2.0",
"react-redux": "^8.0.5",
"string-format": "^2.0.0",
"swiper": "^10.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this Swiper version working well on mobile? I remember I had to downgrade swiper cause they removed touch events in favour of pointer events. At the time, pointer events didn't work well on some mobile devices.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test this @edgardz didn't know 👍

@fzhang13
Copy link
Contributor

fzhang13 commented Oct 6, 2023

This is more of a thought, but should we be moving component into the next-react-ui repo? I feel like component wise we're getting too bloated. Even though I know we use a lot of Carousels on projects sadly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgardz edgardz edgardz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alemesa @experiencemonks-devops @fzhang13 @edgardz