Always build htslib without the libdeflate library #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If libdeflate is installed on the host, the configure script for htslib will pick it up and link with it, leading to undefined symbols in the final link since -ldeflate is missing from PKG_LIBS. We also cannot simply add it to PKG_LIBS, since then we would get an error on hosts where libdeflate is unavailable, so just configure htslib without libdeflate support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If libdeflate is installed on the host, the configure script for htslib will
pick it up and link with it, leading to undefined symbols in the final link
since -ldeflate is missing from PKG_LIBS. We also cannot simply add it to
PKG_LIBS, since then we would get an error on hosts where libdeflate is
unavailable, so just configure htslib without libdeflate support.