Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pull request is not mergeable #27

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

Eun
Copy link
Owner

@Eun Eun commented Sep 21, 2023

Description

Problem

Sometimes the bot responds with pull request is not mergeable, but github shows it is mergable.

Solution

wait a bit if the pull request is not mergale and the last CommitTime is too recent.

Notes

Should fix #25

@Eun Eun force-pushed the wait-if-pull-request-is-not-mergeable branch from ddcbfde to daa9712 Compare September 21, 2023 07:19
@coveralls
Copy link

coveralls commented Sep 21, 2023

Pull Request Test Coverage Report for Build 6258468767

  • 1 of 18 (5.56%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 23.146%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/merge-with-label/worker/should_skip.go 1 18 5.56%
Totals Coverage Status
Change from base Build 6247449103: -0.05%
Covered Lines: 206
Relevant Lines: 890

💛 - Coveralls

@Eun Eun added the merge label Sep 21, 2023
@merge-with-label merge-with-label bot merged commit 7d9367b into main Sep 21, 2023
8 checks passed
@merge-with-label merge-with-label bot deleted the wait-if-pull-request-is-not-mergeable branch September 21, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes the bot returns not merging: pull request is not mergeable
2 participants