Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes the bot returns not merging: pull request is not mergeable #25

Open
Eun opened this issue Sep 19, 2023 · 1 comment · Fixed by #27
Open

Sometimes the bot returns not merging: pull request is not mergeable #25

Eun opened this issue Sep 19, 2023 · 1 comment · Fixed by #27

Comments

@Eun
Copy link
Owner

Eun commented Sep 19, 2023

I suspect this is because github is still in the process of checking whether or not this pull request is mergable.

Two fixes are possible:

  1. Add a retry when this error occurs. While this would fix the problem it would lead to an endless loop of retrying for pull requests that are indeed not mergable. So this would require adding a logic to the current retry logic to stop after X attempts - which would be good in general for this project
  2. The simpler solution would be to either find out if github is still processing or retry when the last update is only X seconds old (similar to the wait logic when a pull request was just updated
    if diff := time.Until(details.LastCommitTime.Add(worker.DurationToWaitAfterUpdateBranch)); diff > 0 {
    )
@Eun
Copy link
Owner Author

Eun commented Sep 21, 2023

I am leaving this open to see if #27 fixed it or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant