Fix: Fixate widget location in UiSettings frame #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When scrolling through data with the slider or using the
Go Towidget, the Settings frame size changes due to the varying length of the first row's text (Window : [...] || Scoring ...), which makes all the widgets in the panel move around a bit.This forces the user to move the mouse before being able to click again on one of the widgets, or may resulte in slight forward scroll in the data when the user tries to backward scroll with the slider. (which are both annoying)
Fix
Use
QGridLayout.addStretchrather thanQGridLayout.addItem(QSpacerItem)to space items in the grid's first rowWith this update, the widgets in the settings bar keep fixed locations during scrolling