Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MNE bdf/gdf EEG file imports #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Teteros
Copy link

@Teteros Teteros commented Nov 8, 2020

Importing .bdf and .gdf currently fails (NME 0.21.1) because those filetypes have their own importers.
This change will make them work again in the Sleep GUI when chosen on open file.

@raphaelvallat
Copy link
Collaborator

Hi @Teteros,

Thank you so much for the PR, and so sorry for the late reply...! The PR looks great. Questio: does that mean that Visbrain will require MNE>0.21.1?

Also worth noting, since MNE 0.22 there is a generic function (https://mne.tools/stable/generated/mne.io.read_raw.html#mne.io.read_raw) that automatically call the appropriate function based on the file extension. But I would prefer to keep compatibility with older versions of MNE for now (at least 0.21).

Thanks
Raphael

@Teteros
Copy link
Author

Teteros commented Feb 21, 2021

does that mean that Visbrain will require MNE>0.21.1?

The minimum version of MNE required for this change is 0.18 I believe
https://github.com/mne-tools/mne-python/blob/main/doc/changes/0.18.inc#L258

as that's when the edf reader was split into BDF/GDF ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants