Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hub-common): add attendees settings pane #1475

Merged
merged 37 commits into from May 9, 2024

Conversation

juliannaeapicella
Copy link
Contributor

  1. Description:

  2. Instructions for testing:

  3. Closes Issues: #8474

  4. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  5. used semantic commit messages

  6. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  7. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

Copy link
Contributor

@rweber-esri rweber-esri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the inline feedback I've left, there's a few more changes you'll need to make on this branch to get it working when you pull this into opendata-ui and start hooking a gallery picker up w/ facets.

  1. You'll need to add a method that returns the events 3 API "definition". I've done this on my branch already, you should be able to copy/paste to your branch for now. See getEventsApiDefinition.ts on PR-1476
  2. You'll need to add a method to determine if the events API should be used for the current call to hubSearch. I've done this on my branch already, you should be able to copy/paste to your branch for now. See shouldUseEventsApi.ts on PR-1476
  3. We need to refactor getApi.ts to use the new methods from 1 & 2 above. I've done this on my branch already, you should be able to copy/paste to your branch for now. See getApi.ts on PR-1476
  4. We need to refactor hubSearch.ts so that it calls through to your new method. I've done similar for searching for events on my branch. See changes in hubSearch.ts on PR-1476

packages/common/src/events/api/utils/search.ts Outdated Show resolved Hide resolved
packages/common/src/events/api/utils/search.ts Outdated Show resolved Hide resolved
packages/common/src/events/api/utils/search.ts Outdated Show resolved Hide resolved
packages/common/src/events/api/utils/search.ts Outdated Show resolved Hide resolved
packages/common/src/events/api/utils/search.ts Outdated Show resolved Hide resolved
Copy link

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

@github-actions github-actions bot added the Stale Stale issue - update or it will be closed label Apr 30, 2024
@juliannaeapicella juliannaeapicella removed the Stale Stale issue - update or it will be closed label Apr 30, 2024
packages/common/src/events/api/orval/api/orval-events.ts Outdated Show resolved Hide resolved
packages/common/src/events/api/utils/search.ts Outdated Show resolved Hide resolved
packages/common/src/types.ts Outdated Show resolved Hide resolved
packages/common/src/events/api/utils/search.ts Outdated Show resolved Hide resolved
@rweber-esri
Copy link
Contributor

As mentioned on opendata-ui PR-13493, there's some quick changes we need to make on this PR to support the front-end behavior:

  1. Extend SortOption to include firstName & lastName
  2. Add a deleteHubEventRegistration method likely in packages/common/src/events/edit.ts that's publicly exported and calls through to the deleteRegistration method in packages/common/src/events/api/registrations.ts. This is needed because the contents of packages/common/src/events/api/registrations.ts are not currently publicly exported due to naming collisions with some of the interfaces.

Copy link
Contributor

@rweber-esri rweber-esri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I believe we have everything we need for the attendees pane.

@juliannaeapicella juliannaeapicella merged commit 0c49423 into master May 9, 2024
5 checks passed
@juliannaeapicella juliannaeapicella deleted the 8474/events-attendees-pane branch May 9, 2024 13:11
esri-dcdev-2 pushed a commit that referenced this pull request May 9, 2024
# @esri/hub-common [14.127.0](https://github.com/Esri/hub.js/compare/@esri/hub-common@14.126.4...@esri/hub-common@14.127.0) (2024-05-09)

### Features

* **hub-common:** add attendees settings pane ([#1475](#1475)) ([0c49423](0c49423))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants