New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hub-common): add attendees settings pane #1475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the inline feedback I've left, there's a few more changes you'll need to make on this branch to get it working when you pull this into opendata-ui
and start hooking a gallery picker up w/ facets.
- You'll need to add a method that returns the events 3 API "definition". I've done this on my branch already, you should be able to copy/paste to your branch for now. See
getEventsApiDefinition.ts
on PR-1476 - You'll need to add a method to determine if the events API should be used for the current call to
hubSearch
. I've done this on my branch already, you should be able to copy/paste to your branch for now. SeeshouldUseEventsApi.ts
on PR-1476 - We need to refactor
getApi.ts
to use the new methods from 1 & 2 above. I've done this on my branch already, you should be able to copy/paste to your branch for now. SeegetApi.ts
on PR-1476 - We need to refactor
hubSearch.ts
so that it calls through to your new method. I've done similar for searching for events on my branch. See changes inhubSearch.ts
on PR-1476
packages/common/src/search/_internal/hubSearchEventAttendees.ts
Outdated
Show resolved
Hide resolved
packages/common/src/search/_internal/hubSearchEventAttendees.ts
Outdated
Show resolved
Hide resolved
packages/common/src/search/_internal/hubSearchEventAttendees.ts
Outdated
Show resolved
Hide resolved
packages/common/src/search/_internal/hubSearchEventAttendees.ts
Outdated
Show resolved
Hide resolved
packages/common/src/search/_internal/hubSearchEventAttendees.ts
Outdated
Show resolved
Hide resolved
packages/common/src/search/_internal/hubSearchEventAttendees.ts
Outdated
Show resolved
Hide resolved
There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label. |
packages/common/src/search/_internal/hubSearchEventAttendees.ts
Outdated
Show resolved
Hide resolved
As mentioned on opendata-ui PR-13493, there's some quick changes we need to make on this PR to support the front-end behavior:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I believe we have everything we need for the attendees pane.
# @esri/hub-common [14.127.0](https://github.com/Esri/hub.js/compare/@esri/hub-common@14.126.4...@esri/hub-common@14.127.0) (2024-05-09) ### Features * **hub-common:** add attendees settings pane ([#1475](#1475)) ([0c49423](0c49423))
Description:
Instructions for testing:
Closes Issues: #8474
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
updated
peerDependencies
as needed. CRITICAL our automated release system can not be counted on to updatepeerDependencies
so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.