Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c] Scale Problem after 4.2 Upgrade #2509

Closed
pinguin999 opened this issue Apr 27, 2024 · 4 comments
Closed

[c] Scale Problem after 4.2 Upgrade #2509

pinguin999 opened this issue Apr 27, 2024 · 4 comments

Comments

@pinguin999
Copy link
Contributor

Hi I stared upgrading ALPACA to Spine 4.2. Most things are working but the speech bubbles (A 9 Patch made via Spine) looks wrong after the update.

The Spine file can be found here:
https://github.com/pinguin999/ALPACA/tree/main/data-src/speechbubble

Images: In Spine and in game 4.1 and 4.2 and the export diff

image
image
image
image

Code Diff: pinguin999/ALPACA@main...spine4_2

Runtime information
c-runtime 4.2

@badlogic badlogic changed the title Scale Problem after 4.2 Upgrade [c] Scale Problem after 4.2 Upgrade Apr 30, 2024
@badlogic
Copy link
Collaborator

@pinguin999 I've taken the speechbubble.spine project from your repo. Exported it with Spine Editor 4.2.08. Here are my exports:

speechbubble.zip

I then loaded those with spine-sfml, which is based on spine-c. They display correctly, both .json and .skel.

Screenshot 2024-04-30 at 10 27 01

Your code changes look correct. Since you include the spine-runtimes repo as a submodule, I'd also guess that you've fully updated to the latest spine-c sources.

I'm afraid since I can't reproduce the issue with spine-c, I can't really help fix this. Could you maybe provide a minimal repro project?

@pinguin999
Copy link
Contributor Author

@badlogic Hi thanks for your feedback.
To reproduce the problem you have to scale the middlemiddle bone.
https://github.com/pinguin999/ALPACA/blob/main/src/dialog/speech_bubble.cpp#L16

Hope that helps to reproduce it.

@badlogic
Copy link
Collaborator

badlogic commented May 2, 2024

Thank you! I was able to reproduce the issue and just pushed a fix to the 4.2 branch.

@pinguin999
Copy link
Contributor Author

I can confirm it's fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants