Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server/config): Implement checked access to server configuration, decoupled from SessionManager #4170

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

whisperity
Copy link
Member

@whisperity whisperity commented Feb 21, 2024

⚠️ Full description WIP!

This commit introduces a new ServerConfiguration handler object which
duty is to deal with all the handling of the configuration options the
servers are started with. Previously, this was done by SessionManager
since a5119f0 (#1249) introduced
non-authentication-related configuration options into the previously
authentication-only configuration file.

The new infrastructure aims to offer a generally user-friendly and more
type-safe way of dealing with configuration options in various parts of
the server package. Options are registered simply akin to adding
options to an argparse parser.

Moved the logic of finding or creating an example server config to the
new class.

The first option, worker_processes has already been refactored into
being handled by the new instance, but there are more to follow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants