Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: order of face joint idx #112

Open
hdjsjyl opened this issue Dec 19, 2023 · 1 comment
Open

Bug: order of face joint idx #112

hdjsjyl opened this issue Dec 19, 2023 · 1 comment

Comments

@hdjsjyl
Copy link

hdjsjyl commented Dec 19, 2023

In skeleton.py line58:
face_joint_idx = [2,1,17,16]
l_hip, r_hip, sdr_r, sdr_l = face_joint_idx

needs to be changed to :
r_hip, l_hip, sdr_r, sdr_l = face_joint_idx

Otherwise: the computed forward direction may be z+ or maybe z-.

@AzureRossi
Copy link

Yes, I mentioned the related bug in issue :Raw code bug in inverse_kinematics_np Function. #107 as well. However, the author may consider it a minor issue, and anyone who has reviewed the code would likely make a quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants