You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for your great work! When studying your wonderful motion representation, I found two small problem which might influence your effects. And they are all in common/skeleton.py.
1. Face Direction
This problem is already mentioned here: #112#107. The direction of the across vector might be wrong.
Here, each joints' position(except roots') will be converted to the rotation about it's parent along kinematic chain. However, not every chain start from root, which means line 85 is not very suitable especially for the arms' chains.
I thought it will be more suitable if it's like:
R=quat_params[:, chain[0]]
Again, thanks for your great work!
The text was updated successfully, but these errors were encountered:
Hi, thanks for pointing this out. Now it would be too late to change the code, since many people have done experiments on the obtained dataset. However, I will highlight your issue, so people will see your comments.
Hi, thanks for pointing this out. Now it would be too late to change the code, since many people have done experiments on the obtained dataset. However, I will highlight your issue, so people will see your comments.
Thanks for your great work! When studying your wonderful motion representation, I found two small problem which might influence your effects. And they are all in
common/skeleton.py
.1. Face Direction
This problem is already mentioned here: #112 #107. The direction of the across vector might be wrong.
HumanML3D/common/skeleton.py
Lines 58 to 62 in 6b72fcd
Which is different from your code in
motion_representation.ipynb
.HumanML3D/motion_representation.ipynb
Lines 85 to 89 in 6b72fcd
This may lead to some errors, but thanks to the redundant 263-dimensional information, this can be recovered to a certain extent
2. Kinematic Chain
This problem may not be as serious as the above.
HumanML3D/common/skeleton.py
Lines 81 to 99 in 6b72fcd
Here, each joints' position(except roots') will be converted to the rotation about it's parent along kinematic chain. However, not every chain start from root, which means line 85 is not very suitable especially for the arms' chains.
I thought it will be more suitable if it's like:
Again, thanks for your great work!
The text was updated successfully, but these errors were encountered: