GUI multi selection #412
Merged
GUI multi selection #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for issue ElmerCSC#441 (ElmerGUI: unable to select multiple surfaces ElmerCSC#411) by leveraging MouseEvent::modifiers() instead of these bool variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to mitigate #411. Three bool variables ctrlPressed, shiftPressed and altPressed were eliminated from GLWidget class. Instead, MouseEvent::modifiers() is directly referred during mouse event slots. Unfortunately I couldn't reproduce the issue maybe because my computer is cheap one. So I can't confirm this fix works, but hopefully solve the issue.