Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes, new features, subclassing support for tagview, NSAttributed String support, and more! #250

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Luke-k-dev
Copy link

Hi!

I added the support for the following:

  • Subclassing TagView. This allows subclassed tags to override their appearance from the tag view. This way you can have tons of differently styled tag in 1 taglistview bug free.
  • NSAttributedString. This allows for text attachment and more customization with tag views. (THis also supports strings for highlight and selected states that are attributed too!)
  • Bug fixes for layout. (When using 2 cells with different font sizes the rows would not layout correctly. This is now fixed.)

I also updated the example project to show how to use the new features. (The hetroTagListView shows how using many different cells works. The custom classes are at the bottom of the view controller.)

Please let me know if there are any problems!

  • Luke

@abdulla-allaith
Copy link

Any plans to merge this?
This would resolve #217 and #41, allowing AttributedString usage.

abdulla-allaith pushed a commit to abdulla-allaith/TagListView that referenced this pull request Mar 21, 2022
@abdulla-allaith
Copy link

This would be a great PR to merge.
I am currently using a fork with this PR merged in PROD.
Working flawlessly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants