Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable the wrapping of tags to next row #126

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jomisj
Copy link

@jomisj jomisj commented Jun 14, 2017

Currently, the tags list is wrapped to next row when the row width gets greater than the view width. So if we have to include the TagListView in a horizontal scrollview its not possible.

I have added a new property wrapTagsToNextRow which is true by default.

    @IBInspectable open dynamic var wrapTagsToNextRow: Bool = true {
        didSet {
            rearrangeViews()
        }
    }

So the default behaviours of the TagListView doesn't change. But if user wish to change wrapTagsToNextRow to false, then all the tags are listed in one row. And this would allow the user to add TagListView to a UIScrollView which can be scrolled horizontally.

… tags to next row

Added an IBInspectable property for TagListView to avoid wrapping the
tags to next row so that TagListView can be used in a scrollview. By
default, the tags wrap to next row
@caesss
Copy link

caesss commented Jun 29, 2017

Great feature! thank you.

@caesss
Copy link

caesss commented Jul 6, 2017

Are there any concerns merging this to the main branch? This is a great solution to a requested feature.

# Conflicts:
#	TagListView/TagListView.swift
@jomisj
Copy link
Author

jomisj commented Feb 19, 2018

@Cee Kindly let me know your thoughts on merging this pull request.

@Cee
Copy link
Collaborator

Cee commented Feb 20, 2018

@jomisj Looks great!
@xhacker Merge this feature into master?

@jomisj
Copy link
Author

jomisj commented Mar 29, 2018

@xhacker Any changes required for merging this pull request?

@adrianod1as
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants