Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo of TagListView in a TableViewController #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aleene
Copy link
Contributor

@aleene aleene commented Dec 3, 2016

This pull request adds a a demo of a TagListView in a TableViewController.

The pull request incorporates the pull requests for Bulk Add (#100) and Storyboard cleanup (#94)

This pull request adds a a demo of a TagListView in a TableViewController.

The pull request incorporates the pull requests for Bulk Add and Storyboard cleanup.

@IBAction func unwindToViewController(_ segue:UIStoryboardSegue) {
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should not have any trailing whitespace

}

func tagRemoveButtonPressed(_ title: String, tagView: TagView, sender: TagListView) {
print("Tag Remove pressed: \(title), \(sender)")
sender.removeTagView(tagView)
}

@IBAction func unwindToViewController(_ segue:UIStoryboardSegue) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colon at column 50 should have exactly one space after it

}

func tagRemoveButtonPressed(_ title: String, tagView: TagView, sender: TagListView) {
print("Tag Remove pressed: \(title), \(sender)")
sender.removeTagView(tagView)
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should not have any trailing whitespace

// Dispose of any resources that can be recreated.
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should not have any trailing whitespace

@@ -33,7 +32,7 @@ class ViewController: UIViewController, TagListViewDelegate {
tagView.onTap = { tagView in
print("Don’t tap me!")
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should not have any trailing whitespace

import UIKit

class ViewController: UIViewController, TagListViewDelegate {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should not have any trailing whitespace

setTags()
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should not have any trailing whitespace

@aquarhead
Copy link
Member

Ebert has finished reviewing this Pull Request and has found:

  • 3 possible new issues (including those that may have been commented here).
  • 2 fixed issues! 🎉

You can see more details about this review at https://ebertapp.io/github/ElaWorkshop/TagListView/pulls/101.

import TagListView

class TagsTableViewCell: UITableViewCell {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line should not have any trailing whitespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants