Use Vite4 or Vite5 manifests, not both #432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going through the same problem. |
|
I just upgraded to Vite 5 and am dealing with this now as well. |
larouxn
reviewed
Mar 25, 2024
vite_ruby/lib/vite_ruby/config.rb
Outdated
| ] | ||
|
|
||
| vite5_manifest_paths = manifest_files.map do |path| | ||
| build_output_dir.join(".vite/#{path}") |
There was a problem hiding this comment.
Suggested change
| build_output_dir.join(".vite/#{path}") | |
| build_output_dir.join(".vite/#{ path }") |
Looks like this repo's RuboCop config wants us to do this. (RuboCop docs)
Lines 72 to 73 in 369facf
There was a problem hiding this comment.
👋 @KieranP, any chance we can get this PR fixed up and rebased? Would be nice to have it ready so it can be merged so it's in the next release, whenever that is. 🙏 🙇♂️
Don't want to keep production application on cherry-picked fix branch long term. 😅
There was a problem hiding this comment.
@larouxn Done and done
This fixes an issue where upgrading to Vite5 was merging old Vite4 and Vite5 manifests together, creating JS errors.
larouxn
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This fixes an issue where upgrading to Vite5 was merging old Vite4 and Vite5 manifests together, creating JS errors.
Background 📜
This was happening because vite_ruby was merging vite4 and vite5 manifests together.
The Fix 🔨
Check for Vite5 manifests. If present, use those, otherwise fall back to Vite4 manifests.
Amends #420