-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow Sticky LS state to persist across EM or optionally across reboot #4978
Conversation
Persistence on EM makes a lot of sense, but I believe not at all on reboot imho. |
On EM, definitely. Across reboot... only as an option. There are times where the LS being able to remember it's state (just like with customisable switches) would be advantageous. |
Could you describe such a scenario? |
For the same reason as with customisable switches... when using momentary switches as 2POS, and remembering the state across reboots. |
That works for customizable switches because they have a led to indicate the state. Bad idea for LS I think |
Even as an option, rather than the default? 🤔 So what happens when I use a SF to adjust a GV to get that persistence? Is that not dangerous also (with more steps, and loss of both SFs and GVs in the process). |
I've added an option flag so users can decide if a Sticky LS should persist across reboots. |
b400aae
to
83524b1
Compare
590c028
to
04de7a9
Compare
04de7a9
to
0b913c4
Compare
Is it at all feasible to add an option like this to the actual LS menu? With all the other options? So you can choose for individual STKY actions. Just throwing that out there (or maybe that’s what this is about and I just can’t interpret the code changed 😂) |
0b913c4
to
c17149b
Compare
LGTM on TX16S and TX12, and read/write to TX12 with companion fine. Simulator for X9D+2019 looks good also... |
Not quite sure what you mean... this adds this as an option to all sticky functions... i.e. you have the option to make the state persistent across reboots. |
After testing it on my radio, I now realize that that was the whole purpose, but I just didn't pay enough attention to the new code 😂 |
Persistence across EM is useful when recovering model state.
Not sure whether persistence on reboot is a good idea or not - opinions?