-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(joystick): add support for Android gamepad features #4626
base: main
Are you sure you want to change the base?
Conversation
SE translation: |
Suggested layouts for tests:
Stick to the order the axis are declared. Applications are supposed to read axis IDs however many do not and use different kinds of position index instead. Similar layouts:
|
Items resolved during compability testing:
Anybody else finding functional items gets a cookie 🍪 |
319e016
to
8ac247e
Compare
Sorry for that - commit history is now squashed and without any merge commits. |
Don't stress over it too much... that's why I said "where possible". As
rebasing after having done merge commits can be messy and prone to things
going wrong. So IMO not is worth the hassle if PR is otherwise
self-contained and doesn't conflict.
…On Sat, 6 Apr 2024, 6:37 am ThomasKuehne, ***@***.***> wrote:
Sorry for that - commit history is now squashed and without any merge
commits.
—
Reply to this email directly, view it on GitHub
<#4626 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJ66KIFIHNKOYIPG3GG57LY34DQBAVCNFSM6AAAAABDDWCKNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGU4TIMRTGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
No worries. |
7f15e29
to
b003f63
Compare
b003f63
to
10f2f0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Did some ... testing ... with FPV Skydive on phone with TX16S as well as checking axis all seem ok on Computer using Gamepad tester.
Used recommended Android order with channels in RTAE order to get the axis right per matching "Gamepad Tester" controller layout on Android...
https://manual.edgetx.org/edgetx-how-to/configure-advanced-joystick-with-edgetx#common-axis-mapping
Can we get some translations for this please 😃 Will be merged in seven days or when translations complete, whichever comes first.
|
DE
How many chars do we have space for? I assumed 5 based on "Steer" |
CN #define TR_VUSBJOYSTICK_CH_SIM "横滚","俯仰","航向","油门","加速","刹车","转盘","方向"
#define TR_VUSBJOYSTICK_CIRC_COUTOUT "无","X-Y, Z-rX","X-Y, rX-rY","X-Y, Z-rZ" TW #define TR_VUSBJOYSTICK_CH_SIM "橫滾","俯仰","航向","油門","加速","剎車","轉盤","方向"
#define TR_VUSBJOYSTICK_CIRC_COUTOUT "無","X-Y, Z-rX","X-Y, rX-rY","X-Y, Z-rZ" |
FR:
#define TR_VUSBJOYSTICK_CH_SIM
"Ail","Prof","Dir","Gaz","Acc","Frein","Gouv","Dpad"
#define TR_VUSBJOYSTICK_CIRC_COUTOUT "Aucun","X-Y, Z-rX","X-Y,
rX-rY","X-Y, Z-rZ"
Le mer. 29 mai 2024 à 14:53, Peter Feerick ***@***.***> a
écrit :
… How many chars do we have space for? I assumed 5 based on "Steer"
I would try to keep it under 9 characters... this is the space it would
fit in... (it's the Sim axis value)
image.png (view on web)
<https://github.com/EdgeTX/edgetx/assets/5500713/c50be87b-057f-4403-b8f3-3c736900b914>
—
Reply to this email directly, view it on GitHub
<#4626 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6HE7XKCEVXREEOVDEUUCITZEXFTZAVCNFSM6AAAAABDDWCKNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZXGM2DGNZVGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
IT #define TR_VUSBJOYSTICK_CH_SIM "Ale","Ele","Dir","Mot","Acc","Fre","Sterz","Dpad" |
DA (insert after line 160) |
CZ: #define TR_VUSBJOYSTICK_CH_SIM "Ail","Ele","Rud","Thr","Acc","Brk","Steer","Dpad" Quite difficult to translate some of them to Czech... because somebody uses translated ones. somebody uses English international names... |
Some applications with direct HID raw processing expect require D-Pad keys instead of the POV axisw.
fcd0b7b
to
49bcbf1
Compare
PT: |
JP: |
here be dragons - diverse tests required, USB HID support is sometimes ... picky
enhancements to the USB joystick - all Google mandated features for Android gamepads, except for the back key, are supported
For Android use the USB Joystick Mode "Advanced" with "If.mode" Gamepad:
notes:
Footnotes
triggers - check "advanced joystick howto" for EdgeTX/edgetx#4626 edgetx-user-manual#29 how to feed these half axis ↩ ↩2
D-pad - check "advanced joystick howto" for EdgeTX/edgetx#4626 edgetx-user-manual#29 how to feed this special axis ↩
these do work on most Android devices, however their support isn't mandatory ↩ ↩2 ↩3 ↩4 ↩5 ↩6 ↩7