Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding attendees to a meeting invitation #293

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding attendees to a meeting invitation #293

wants to merge 3 commits into from

Conversation

YazeedFares
Copy link

Would you please check these changes and let me know if you have any feedback, I tested this new feature on Android 5.1.1 and iOS 8 and 9

@@ -513,7 +495,7 @@ public void run() {
calendar_end.setTime(date_end);

//projection of DB columns
String[] l_projection = new String[]{"calendar_id", "title", "begin", "end", "eventLocation", "allDay", "_id"};
String[] l_projection = new String[]{"calendar_id", "title", "begin", "end", "eventLocation", "allDay"};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did "_id" go?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, I didn't change this area !!

I will check tomorrow
On May 23, 2016 10:43 PM, "Eddy Verbruggen" notifications@github.com
wrote:

In src/android/nl/xservices/plugins/Calendar.java
#293 (comment)
:

@@ -513,7 +495,7 @@ public void run() {
calendar_end.setTime(date_end);

       //projection of DB columns
  •      String[] l_projection = new String[]{"calendar_id", "title", "begin", "end", "eventLocation", "allDay", "_id"};
    
  •      String[] l_projection = new String[]{"calendar_id", "title", "begin", "end", "eventLocation", "allDay"};
    

Where did "_id" go?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/EddyVerbruggen/Calendar-PhoneGap-Plugin/pull/293/files/4660ce3b561ddb2231a2a84a8126fba2c74ba30b#r64275947

@EddyVerbruggen
Copy link
Owner

Hi @YazeedFares that's much cleaner than the previous PR 👍

Looking closer at the PR there are more changes than only adding the attendees. Do you want to elaborate on them so I know what's changing when I merge this? Or should I just extract the attendees bits?

Cheers,
Eddy

@theunreal
Copy link

@EddyVerbruggen Any updates on this? Adding attendees is a core calender feature

@EddyVerbruggen
Copy link
Owner

No news from me.

@paolocarrara
Copy link

@EddyVerbruggen Do you mind if I tackle this issue? I have it already working in android, it is far from fully tested but works at creating events interactively. I think I can do a pull request by tomorrow. (I'm not reusing this pull request code, created my own)

@EddyVerbruggen
Copy link
Owner

@paolocarrara Of course, please go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants