Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Invalid Fields structure #312

Merged
merged 4 commits into from
Apr 12, 2024
Merged

[fix] Invalid Fields structure #312

merged 4 commits into from
Apr 12, 2024

Conversation

nwithan8
Copy link
Member

Description

Port of fix in .NET library to Java.

Fun fact: The Fields object in this library previously did not have any properties declared. This means there was never any deserialization issues, but also means that each Field was never reachable by end-users.

Testing

  • Add unit test to confirm deserialization works as expected
    • The carrier accounts used in our existing unit tests do not have fields returned by the API, so the serialization issue was not previously caught.
    • Beyond that, the properties of Fields were not declared, so they were never deserialized.

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team as a code owner April 12, 2024 18:46
@nwithan8 nwithan8 marked this pull request as draft April 12, 2024 18:48
@nwithan8 nwithan8 marked this pull request as ready for review April 12, 2024 18:52
@nwithan8 nwithan8 merged commit 791a6b4 into master Apr 12, 2024
17 checks passed
@nwithan8 nwithan8 deleted the carrier_fields branch April 12, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants