Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Clean up dependency groups in nuspec #563

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented May 1, 2024

Description

Following recommended best practices, as warned by our CI:

WARNING: NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below:

  • Add lib or ref assemblies for the netcoreapp3.1 target framework

WARNING: NU5130: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder have compatible matches, but not exact matches in the other location. Unless intentional, consult the list of actions below:

  • Add a dependency group for net8.0 to the nuspec

Removed unused 3.1 dependency group, added explicit 8.0 group

This does not impact users' ability to install and use our library, but does clear up inconsistencies and follows best practices

Testing

  • No warning during build process now

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team as a code owner May 1, 2024 16:45
@nwithan8 nwithan8 merged commit 7f98558 into master May 1, 2024
14 checks passed
@nwithan8 nwithan8 deleted the nuget_deps branch May 1, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants