Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(examples): using Vite to refactor examples. #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lcandy2
Copy link

@lcandy2 lcandy2 commented Mar 23, 2024

  • Use npm instead of yarn to minimize potential Cannot resolve dependency errors
  • Using package.json, list the required packages in it
  • Using Vite for Faster Packaging
  • This pr is aim to help make examples more modern and easier to publish online
  • Wrote README within the example

use npm instead of yarn to improve compatibility
@E-Kuerschner
Copy link
Owner

hey @lcandy2 thanks for the examples revamp! On the package.json change, any reason you think we shouldn't still use the installed node_modules from the project root with the alias field as the current package.json does?

@lcandy2
Copy link
Author

lcandy2 commented Mar 29, 2024

Yeah, that makes sense, I’m going to use npm workspace to make this example alias the current repo exists.

@E-Kuerschner
Copy link
Owner

Yeah, that makes sense, I’m going to use npm workspace to make this example alias the current repo exists.

@lcandy2, great! Once that tweak is pushed up we can get this improvement in. Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants