Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#6262: query cpu id for scheduler output streams #6263

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

prasun3
Copy link
Contributor

@prasun3 prasun3 commented Aug 11, 2023

Added an API to query cpu id

Issue: #6262

Added an API to query cpu id

Issue: #6262
@prasun3 prasun3 linked an issue Aug 11, 2023 that may be closed by this pull request
* MAP_TO_RECORDED_OUTPUT and returns -1 for other mappings.
*/
virtual int
get_output_cpuid(output_ordinal_t ordinal)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We figured this would be on the stream, not the scheduler. We may also want this for other modes, including core-oriented analysis tool modes #5694, where it has to be on the stream as the scheduler is not exposed through the analyzer framework.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up needing this for #5694 and I put it into PR #6279 -- does that meet your needs as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like this should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to query cpu id for scheduler output streams
3 participants