Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Blur support Android & Ios. #993

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

HyopeR
Copy link

@HyopeR HyopeR commented Jul 3, 2023

Hello everyone.

I recently had to develop a blur for this package in a project that works on both platforms.
There were several pull requests and issues opened for this, but none of them were fully completed.

Usage example

<FastImage
    style={{width: 100, height: 100}}
    source={source}
    blurRadius={25}
/>

Related pull requests

#591 #531 #157

Related issues

#127 #827 #801 #726 #604 #50

Outputs

Android Ios
android ios

@HyopeR HyopeR changed the title Feat: Blur support Android & Ios support. Feat: Blur support Android & Ios. Jul 3, 2023
@cygnet-umshah
Copy link

It is not working for me.

@HyopeR
Copy link
Author

HyopeR commented Jul 4, 2023

@cygnet-umshah I am using it in an application that I have brought live. I have verified that it is successful in real device and simulator tests. On which device did you try it?

Can you do a test with the fork I created, in order to reach a definite conclusion? (Main branch)
I changed the way it is loaded in the main branch. You can test it directly by executing

npm i https://github.com/HyopeR/react-native-fast-image

Delete and reinstall pods for ios.
Don't forget to clean gradlew for android.

@cygnet-umshah
Copy link

cygnet-umshah commented Jul 4, 2023

I did the same and actually I forked library and then merge your PR into it but blur radius does not working. I am using ProgressiveFastImage so FastImage along with animated. also try without that as well still no behavior change. I need my background to be blur.

Android solution works fine but not iOS.

@cygnet-umshah
Copy link

I will check and also get back to you

@cygnet-umshah
Copy link

Not able to install from your repository it is giving error.
Screenshot 2023-07-05 at 1 41 39 PM

@HyopeR
Copy link
Author

HyopeR commented Jul 10, 2023

@cygnet-umshah

Hello, you are right. I haven't tested this in a project where I use typescript. I think there was a problem with the version of bob builder.

I downgraded the package and tested it. You shouldn't encounter a typescript error right now. Can you try again when you have time?

npm i https://github.com/HyopeR/react-native-fast-image

@Johnathon332
Copy link

I just tried again and it doesn't work, I get the same error as above

@vinnyA3
Copy link

vinnyA3 commented Aug 28, 2023

is this working yet?

@HyopeR
Copy link
Author

HyopeR commented Aug 28, 2023

I am currently using this repository in my 2 projects that are live. I couldn't reproduce the typescript error mentioned above in my local.

I only have one idea for this. If you try to install a package using 'yarn' in the project in any github repository it is a known bug that it ignores some fields contained in 'package.json'. The above issue may be caused by this. (NOTE: This does not apply to Yarn Berry.)

Here is the topic; yarnpkg/yarn#2822

@vinnyA3 If you are using npm, pnpm or yarn/berry in your project, can you try installing from here?

npm i https://github.com/HyopeR/react-native-fast-image

If you have the same error, I will try to solve the typescript problem of the pull request.

@vinnyA3
Copy link

vinnyA3 commented Aug 30, 2023

Interesting 🤔 @HyopeR -- okie, thanks for this feature request by the way - I am looking to try in one of my projects, and will most likely try a patch here.

That said, I'll be happy to see if I can reproduce this error on a clean project. I'll use different versions of yarn, as well as npm, to see.

@JoeDareZone
Copy link

It's working for me! Using Expo Dev Client and TypeScript. Thanks a million @HyopeR

@HyopeR
Copy link
Author

HyopeR commented Sep 11, 2023

@JoeDareZone I'm glad it worked. Thanks for testing.

@Tchaikovsky1114
Copy link

that's can not apply RN version. 68.2

@HyopeR
Copy link
Author

HyopeR commented Mar 15, 2024

@Tchaikovsky1114 What do you mean? Blur feature not working on React Native 0.68.2+? Or do I have a different compilation problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants