Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed graphics context allocation issue #1007

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aman32767
Copy link

@aman32767 aman32767 commented Sep 25, 2023

Title: Resolved Graphics Context Allocation Issue

Description:

Proposed Changes
This PR resolves an issue pertaining to graphics context allocation in the FFFastImageViewManager. The previous implementation utilized older graphics context handling methods, which could potentially lead to errors. This PR updates the code to leverage the newer UIGraphicsImageRenderer API, mitigating any context allocation problems.

Changes Made

  • Updated FFFastImageViewManager.m to utilize UIGraphicsImageRenderer for managing image context.
  • Eliminated manual handling of context creation and cleanup, reducing the likelihood of errors.

Graphics Context Handling:
It now employs UIGraphicsImageRenderer, a more modern API introduced in iOS 10. This API handles the creation, rendering, and cleanup of the image context automatically.

Renderer Usage:
It now creates a UIGraphicsImageRenderer object (renderer) and employs it to execute the drawing operations.

Error Handling:
It leverages a more modern API that is less susceptible to context allocation errors.

This PR addresses: #1006

This was referenced Sep 25, 2023
@AdamGerthel
Copy link

AdamGerthel commented Sep 25, 2023

Works well for me on iOS 17

@MuhammadMuzammilQadri
Copy link

Working fine on iOS 17. Thanks

@johanholm
Copy link

@DylanVann Please merge

@fukemy
Copy link

fukemy commented Oct 7, 2023

someone please tell me how to install this pull by npm

@AdamGerthel
Copy link

someone please tell me how to install this pull by npm

You can apply a patch, see #1002 (comment)

@mohitarora777
Copy link

@AdamGerthel I already have a patch applied for fast image in podsec file. Can u tell how can we apply multiple patches to same lib ?

@AdamGerthel
Copy link

AdamGerthel commented Oct 10, 2023

@AdamGerthel I already have a patch applied for fast image in podsec file. Can u tell how can we apply multiple patches to same lib ?

I don't understand exactly what you mean by "I already have a patch applied for fast image in podsec file" - could you be a bit more specific? If you want to understand how to apply a patch for an npm package, the best way is to read the usage instructions for patch-package.

@mohitarora777
Copy link

mohitarora777 commented Oct 10, 2023

Got it thanx @AdamGerthel

@Strate
Copy link

Strate commented Nov 9, 2023

Thank you for this!

@hadnet
Copy link

hadnet commented Jan 14, 2024

@DylanVann please, man, merge this.

@Nazim-hasan
Copy link

@DylanVann please, merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet