add workflows #1
Conversation
Cargo.toml
Outdated
| async-trait = "0.1.78" | ||
| base64 = "0.22" | ||
| bytes = "1.5" | ||
| destream = "0.7" | ||
| futures = "0.3" | ||
| number-general = { version = "0.11", optional = true } | ||
| number-general = { version = "0.11.1", optional = true } | ||
| pin-project = "1.1" | ||
| tokio = { version = "1.35", features = ["io-util"], optional = true } | ||
| uuid = "1.6" | ||
|
|
||
| [dev-dependencies] | ||
| number-general = { version = "0.11", features=["stream"] } | ||
| number-general = { version = "0.11.1", features=["stream"] } |
There was a problem hiding this comment.
updated these versions as an attempt to get this minimal-versions test working, but ended up dropping it since number-general depends on another of your crates that breaks this check:
cargo generate-lockfile -Z minimal-versions
cargo check --locked
src/constants.rs
Outdated
There was a problem hiding this comment.
these are all a clippy warning, these refs are 'static by default
| } else if (self.buffer.len() >= FALSE.len() && self.buffer.starts_with(FALSE)) | ||
| || (self.buffer.len() >= TRUE.len() && self.buffer.starts_with(TRUE)) | ||
| { | ||
| self.decode_bool(visitor).await |
There was a problem hiding this comment.
should maybe make sure a test covers this, but clippy complained that these two condition blocks were the same, so i combined the conditions
| struct Error; | ||
|
|
||
| impl<'en> IntoStream<'en> for Error { | ||
| fn into_stream<E: Encoder<'en>>(self, encoder: E) -> Result<E::Ok, E::Error> { | ||
| "an error!".into_stream(encoder) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
clippy complained this was unused, is it?
Cargo.toml
Outdated
| @@ -18,18 +18,18 @@ value = ["number-general/stream"] | |||
| all = ["tokio-io", "value"] | |||
|
|
|||
| [dependencies] | |||
| async-trait = "0.1" | |||
| base64 = "0.21" | |||
| async-trait = "0.1.78" | |||
There was a problem hiding this comment.
Is there a reason why you need this specific patch version?
There was a problem hiding this comment.
see this comment and this comment on the specific action.
since we're not running this action, these changes can be reverted, but technically a project won't compile if it requires, for example, async-trait ==v0.1.0. i think i'll revert these changes for now and we can revisit in a future PR.
Cargo.toml
Outdated
| bytes = "1.5" | ||
| destream = "0.7" | ||
| futures = "0.3" | ||
| number-general = { version = "0.11", optional = true } | ||
| number-general = { version = "0.11.1", optional = true } |
| struct Error; | ||
|
|
||
| impl<'en> IntoStream<'en> for Error { | ||
| fn into_stream<E: Encoder<'en>>(self, encoder: E) -> Result<E::Ok, E::Error> { | ||
| "an error!".into_stream(encoder) | ||
| } | ||
| } | ||
|
|
No description provided.