Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a find_package(UMFPACK) bug in ParU/CMakeLists.txt #793

Merged
merged 3 commits into from
May 20, 2024

Conversation

valgur
Copy link

@valgur valgur commented Apr 1, 2024

External UMFPACK is currently not being found due to a small bug in ParU/CMakeLists.txt.

@valgur valgur changed the base branch from dev to dev2 April 1, 2024 09:02
@mmuetzel
Copy link
Contributor

mmuetzel commented Apr 3, 2024

Oof. That's probably a copy-paste error that wasn't caught by CI because CAMD_FOUND happened to be set after find_package(CHOLMOD).

Your change looks good to me. Thank you for your contribution. 👍

Edit: Strike that previous remark. The CI didn't catch it because it is linking to the CHOLMOD libraries in the common build or source tree. 🤦
Your change still looks good though. 👍

@DrTimothyAldenDavis
Copy link
Owner

Thanks for the catch.

I realize this is a very minor change, but my organization requires that any contributor signs a contributor agreement (a copy is at the top-level in SuiteSparse). Can you sign it and send it to me?

@mmuetzel
Copy link
Contributor

This change fixes a bug in the current CMake rules. I'm assuming that @valgur didn't respond in more than 6 weeks. With that in mind, what should be done with this change?

@valgur
Copy link
Author

valgur commented May 17, 2024

I emailed my signed contributor license now. Apologies for the delay.

@DrTimothyAldenDavis DrTimothyAldenDavis merged commit 33e46bd into DrTimothyAldenDavis:dev2 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants