Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for importing video stickers #1701

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MSDarwish2000
Copy link

This pull request contains a few code changes to enable video stickers importing.

Currently, though documentation of Importing Stickers to Telegram mentions that it is possible to import video stickers the Android client cannot handle them. I've tried to report this issue through e-mail with no response, so decided to try and make the required changes. Hope this finds its way to the developers.

Changes

  • updating "TL_stickers_createStickerSet"
  • detecting WebM magic bytes
  • adding necessary isVideo fields to certain models
  • changes in "StickerEmojiCell" for previewing WebM to work

What needs to be reviewed

  • Whether it is necessary to validate WebM first? If yes, local or remote?
  • code changes made in "StickerEmojiCell"

This commit contains code changes to enable video stickers importing. These changes include:
 - updating "TL_stickers_createStickerSet"
 - detecting WebM magic bytes
 - adding necessary isVideo fields to certain models
 - Changes in "StickerEmojiCell" for previewing WebM to work

 What needs to be reviewed:
 - Whether it is necessary to validate WebM first? If yes, local or remote?
 - Code changes made in "StickerEmojiCell"
@MSDarwish2000
Copy link
Author

@xaxtix @DrKLO

@stayf
Copy link

stayf commented May 20, 2022

@xaxtix @DrKLO Добрый день. Слейте пожалуйста этот MR, если он корректный. Давно уже жду поддержи видеостикеров для сторонних приложений под андроид. В Ios поддержка со дня релиза видеостикеров, андроид отстает.

@Mr-lidajun
Copy link

Mr-lidajun commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants