Support Neo4j Native datetime Types for Serialization Through Client Setting #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgraded to the 5.1.0 version of the Driver Fixed tests, and switched to use the new API.
…into global-datetime-setting
|
Thank you for this @arturosevilla - Sorry it took so long to get into the client. I agree a direct Bolt serializer would be preferable, and I know about the old PR, and I'm sorry it hasn't got in yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that the desire to use native datetime instances is growing specially with issue #332 that, although
Neo4jDateTimeAttributeexists it does not support a comparison with a parameter that is not added through.WithParam(). Therefore I took suggestion there to create a "global" (client instance) setting that switches such behavior.In fact, my PR #275 wished to address this as well (I will continue with this PR as I intend to have a direct serializer instead of still going through creating an intermediate JSON representation).