Check if querystring isset before adding questionmark to destinationUrl #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that this commit does not remove the question-mark. |
|
Shouldn't it be on line 90 if ($queryString) { // instead of isset($querystring) |
Can confirm this works. |
|
Confirmed, would you consider updating your PR please @dennisadriaans? And then hopefully someone can merge it in 🙌 |
|
I updated the PR as requested. |
|
Can someone merge this please? |
|
Can confirm this works. Please merge 🙏 |
|
I also can confirm this works. I hope this gets merged soon. |
|
Is this still waiting to merge the fix? v2.0.1 installed and still has the "?" on redirects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google complains about an alternate page with proper canonical tag because for every redirect there is a question mark added to the destination URL.