fix: Prevent extra blank lines on list items #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ricardo Amaral <ricardo@doist.com>
✅ Deploy Preview for doist-typist ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rfgamaral
approved these changes
Mar 6, 2024
|
I managed to add tests for the new functionality. Now I can truly say I contributed something here 😅 |
doistbot
added a commit
that referenced
this pull request
Mar 6, 2024
## [4.0.5](v4.0.4...v4.0.5) (2024-03-06) ### Bug Fixes * Prevent extra blank lines on list items ([#685](#685)) ([b538ebe](b538ebe))
|
🎉 This PR is included in version 4.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR applies a fix devised by Ricardo in https://github.com/Doist/Issues/issues/13081#issuecomment-1980648452. Once this is released in a new Typist version, and incorporated into todoist-web, that issue will be fixed.
PR Checklist
README.mdTest plan
See demo below. Check that in this PR's storybooks deployment the issue does not happen anymore.
Demo
CleanShot.2024-03-06.at.12.49.46.mp4
CleanShot.2024-03-06.at.12.53.19.mp4