test: Introduce visual regression tests using Playwright #732
+1,743
−563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnapse
force-pushed
the
ernesto/vrt/playwright
branch
9 times, most recently
from
87f3f88
to
32dd32f
Compare
gnapse
force-pushed
the
ernesto/vrt/playwright
branch
from
32dd32f
to
e4ac4e3
Compare
|
Something introduced in this PR has broken the tsdx build command. I noticed first on CI, but when I run it locally I can reproduce. To do so, run this command locally: tsdx build --tsconfig tsconfig.dist.jsonThe closest I've found online related to the error message is rollup/rollup#3591. Maybe tsdx is using a rollup version older than the one in which a fix for that issue was released. Meaning we really need to get rid of tsdx soon. |
According to package-lock, tsdx is using 2.79.1. The fix went live with 2.11.0. Must be something else 😞
This is true regardless, and might be the easier solution than figuring out the root cause here 😅 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Work in progress.
See https://twist.com/a/1585/ch/607587/t/3963022/
PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refnpm run build-all)Versioning