Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for obsolete names #41

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

goncalossilva
Copy link
Member

While working on #40, I noticed we use several obsolete timezone names:

python-timezones – _defs py 2023-10-04 at 11 39 49 AM

For example, most of those Europe/ should either be Europe/Brussels or Europe/Prague according to IANA.

On the one hand, I'm concerned about how much we're falling behind. E.g., it's been a long while since America/Godthab has been replaced with America/Nuuk.

On the other hand, if we follow IANA's deprecations, we'll greatly simplify our list, but we may lose some user-friendliness. E.g., Europe/Copenhagen is obsolete in favor of Europe/Berlin and would be completely gone. Is that OK?

Thoughts @amix?

@amix
Copy link
Member

amix commented Oct 4, 2023

Thoughts @amix?

It was many years ago I looked into this. I don't have any strong opinions here; we should follow the current best practices 😊

@goncalossilva
Copy link
Member Author

I wish I knew what “best practices” are in this context. 😅 My instinct is to follow IANA, but the whole debate about timezones doesn't feel very user-friendly in general.

Europe/Copenhagen is obsolete in favor of Europe/Berlin and would be completely gone. Is that OK?

How would you feel about this, as a user?

@amix
Copy link
Member

amix commented Oct 5, 2023

Europe/Copenhagen is obsolete in favor of Europe/Berlin and would be completely gone. Is that OK?
How would you feel about this, as a user?

I would not care a lot, I think. Most Europeans are probably very timezone aware, and it would be easy to pick a city that's in the same timezone 🤔

@goncalossilva
Copy link
Member Author

In that case, I wonder if we should stop hard-coding a list of these ourselves and simply use IANA's of current defaults (minus deprecations). In other words, to generate these at runtime. I'll mention this in a team meeting, I may be missing something.

@amix
Copy link
Member

amix commented Oct 9, 2023

Could make sense, @goncalossilva! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants