Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update readme for contains -> includes #394

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update readme for contains -> includes #394

wants to merge 2 commits into from

Conversation

vfuto
Copy link

@vfuto vfuto commented Jan 12, 2021

Changes proposed in this pull request

Updated readme for includes helper (from 4.3.0 contains helper changed to includes)

@snewcomer
Copy link
Contributor

HI Viktor! I think we want to merge this when we release 5.0.0 as it is deprecated in 4.0.0 series. What do you think?

@vfuto
Copy link
Author

vfuto commented Jan 12, 2021

Hey Scott, sounds good to me! Thanks 🙏

@bertdeblock
Copy link
Contributor

I created #397 before noticing this PR. includes should still be documented though. See #393.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vfuto @snewcomer @bertdeblock