Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make isPointInsidePath() more robust by adding jitter to cast ray. #1131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make isPointInsidePath() more robust by adding jitter to cast ray. #1131

wants to merge 1 commit into from

Conversation

samhocevar
Copy link

Fixes #1130.

samhocevar added a commit to samhocevar-forks/raphael-boolean that referenced this pull request Mar 5, 2021
@samhocevar
Add explicit random jitter to intersection checks.
0767c82 
This works around a Raphael.isPointInsidePath limitation. There was a workaround
mentioned in poilu#3 (comment)
but it is vulnerable to corner cases. A fix was also proposed upstream at
DmitryBaranovskiy/raphael#1131
@samhocevar samhocevar mentioned this pull request Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve isPointInsidePath() robustness
1 participant
@samhocevar