Several fixes for issues with bar and pie chart #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ike this behaviour and it caused problems with the labels/colours so removed it. minPercent and maxSlices functionality modified in order to take account of this. VBarchart - labels fixed (they just didn't work before). Modified behaviour so that if a label overlaps a previous label then Raphel will draw the label lower rather than just removing it. G.Raphael - I was running into a problem where the popup would move up the page each time it appeared. I've fixed this for my case, not sure if it breaks other cases or not though..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pie chart - old version re-ordered data into order by value. Didn't like this behaviour and it caused problems with the labels/colours so removed it. minPercent and maxSlices functionality modified in order to take account of this.
VBarchart - labels fixed (they just didn't work before). Modified behaviour so that if a label overlaps a previous label then Raphel will draw the label lower rather than just removing it.
G.Raphael - I was running into a problem where the popup would move up the page each time it appeared. I've fixed this for my case, not sure if it breaks other cases or not though..