Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venturechat 4.0 #1643

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from
Draft

Venturechat 4.0 #1643

wants to merge 20 commits into from

Conversation

Aust1n46
Copy link
Contributor

No description provided.

Copy link

Your PR was set to master but as our Contributing Guidelines state, PRs should be sent to develop
The base branch of this PR has been automatically changed to develop, please check that there are no merge conflicts.

@github-actions github-actions bot changed the base branch from master to develop February 12, 2024 06:02
@Aust1n46 Aust1n46 marked this pull request as draft February 12, 2024 06:03
Copy link
Member

@granny granny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will take a closer look at the code at a later date

src/main/java/github/scarsz/discordsrv/DiscordSRV.java Outdated Show resolved Hide resolved
build.gradle.kts Outdated
@@ -272,6 +272,8 @@ dependencies {
compileOnly("mineverse.aust1n46:venturechat:2.20.1")
compileOnly("com.comphenix.protocol:ProtocolLib:4.5.0")

compileOnly(files("VentureChat-4.0.0.jar"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need to wait for an updated VentureChat build in scarsz' repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that you will want both versions to maintain backwards compatibility.

VentureChat-4.0.0.jar Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants