-
-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added linking bypass perm #1510
base: develop
Are you sure you want to change the base?
Conversation
Seems unnecessary to have a toggle for the permission, that's the permission plugin's job That said, the reason this has never been implemented is because the link requirement check happens before the player has even fully joined the server... this means that (most?) permissions plugins don't have the player's permissions loaded just yet. Have you tested this? Which permissions plugin? |
Haven't tested it yet, I've seen some perm loading go fast enough but it just depends what you have loaded. I'll try it right now with a server with 30ish plugins |
Yeah, doesn't load fast enough, in theory could the login event be pushed to nonpre if they enable the perm? |
Did some poking around, currently DSRV defaults to listening to Obviously this only applies to LP, but given it's got the vast majority of the marketshare, I figure that's probably all that really matters. |
(My alt) |
If I understand this correctly, this feature would surely be appreciated by many server owners. I looked for a way to enforce discord linking at a later point than the first join to make the first join as user-friendly as possible. The plan was to give beginner ranks the bypass permission and as soon as they got used to the server concept and ranked up, they would need the discord linking. |
You could lock things behind the discordsrv:linked luckperms context |
based on #1491