-
-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LunaChat Hook #1484
base: develop
Are you sure you want to change the base?
Update LunaChat Hook #1484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I understanding this right, that there would be a secondary message containing the native text and another with the roman version?
eg.
Vankka > konnichiwa
[JP] こんいちわ
Thanks for the PR!
Your understanding is right. It is certainly better that way. |
I'd prefer having this as a separate config file. The main config file should be options for DiscordSRV specifically. A |
# LunaChat converted message | ||
# LunaChatConvertedMessageFormat: the format used when sending LunaChat converted messages to Discord | ||
# LunaChatConvertedMessageFormatNoPrimaryGroup: used in place of LunaChatConvertedMessageFormat | ||
# when no primary group for the player was found | ||
# Available placeholders: | ||
# %username%: raw player username | ||
# example: jeb_ | ||
# %displayname%: display name from things like nicknames | ||
# example: BigBossManJeb | ||
# %usernamenoescapes%: raw player username without escaping discord format (for use in inline code & code block markdown) | ||
# example: jeb_ | ||
# %displaynamenoescapes%: display name from things like nicknames without escaping discord format (for use in inline code & code block markdown) | ||
# example: BigBossManJeb | ||
# %original%: original message content | ||
# 例: konnnitiha | ||
# %message%: converted message content | ||
# 例: こんにちは | ||
# %primarygroup%: the name of the user's primary group | ||
# %world%: name of world player is in | ||
# example: world | ||
# %worldalias%: alias of world player is in via Multiverse-Core | ||
# example: Mainland | ||
# %date%: current date & time | ||
# example: Sun Jan 1 15:30:45 PDT 2017 | ||
# %channelname%: the name of the channel that the message was sent in, if the message was sent in a channel at all | ||
# example: Global | ||
# PlaceholderAPI placeholders are also supported | ||
|
||
LunaChatConvertedMessageFormat: "`[JP] %message%`" | ||
LunaChatConvertedMessageFormatNoPrimaryGroup: "`[JP] %message%`" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to separate lunachat.yml
file
# %channelname%: the name of the channel that the message was sent in, if the message was sent in a channel at all | ||
# example: Global | ||
# PlaceholderAPI placeholders are also supported | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No trailing newline after comments
I apologize for not being able to reply for several months due to being busy. While I think that the idea of separating the config files is great, the current I think it would be easier for users to either create a new config file for the hook plugin ( |
What did I do?
Why?
Many people using LunaChat use the Japanese conversion feature (called Japanize in LunaChat) as well as the channel chat function. However, when using the channel chat function, the Japanese conversion string is not sent to Discord. Therefore, I wrote code so that the Japanese conversion string can also be sent to Discord.
And some Japanese translations were strange, so I fixed them.