Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhauled internal account linking implementations #1150

Open
wants to merge 77 commits into
base: develop
Choose a base branch
from
Open

Overhauled internal account linking implementations #1150

wants to merge 77 commits into from

Conversation

Scarsz
Copy link
Member

@Scarsz Scarsz commented Jun 7, 2021 •
edited by granny

Recreation of #865 because GitHub lost track for some reason after rebasing

TODO:

@Scarsz
only log API listener subscription if it's not for internal usage
7beb76e
@Scarsz
add internal implementation and framework for new account linking int…
6496498 
…ernals
@Scarsz
wrong import
410a708
@Scarsz
add deprecated getter to keep API backwards compatibility
ba5f0ef
@Scarsz
log non-404 status codes in MinecraftAuthenticationService
b5561f0
@Scarsz
add async methods to account providers
21a8661
@Scarsz
bump JDA
8210f00
@Scarsz
Rebase
fdb9f6d
@Scarsz
Rebase
5e6d773
@Scarsz
wrong import
1642afd
@Scarsz
add deprecated getter to keep API backwards compatibility
f44bde1
@Scarsz
log non-404 status codes in MinecraftAuthenticationService
aabe58d
@Scarsz
add async methods to account providers
028cc32
@Scarsz
Merge remote-tracking branch 'origin/linking-overhaul' into linking-o…
26906ae 
…verhaul

# Conflicts:
#	pom.xml
#	src/main/java/github/scarsz/discordsrv/api/ApiManager.java
#	src/main/java/github/scarsz/discordsrv/objects/managers/AccountLinkManager.java
@Scarsz
add license headers
3828529
@Scarsz
fix rest of rebasing issues
8df287a
@Scarsz
convert MinecraftAuth account service to use MinecraftAuth lib
d86f58b
@Scarsz
unify variable names
8ebf98c
@Scarsz
abstract SQL account system functionality
f9b4c69
@Scarsz
comment
a5a093e
@Scarsz
implement AccountSystem #toString's
650f309
@Scarsz Scarsz linked an issue Jun 7, 2021 that may be closed by this pull request
Link account via slash commands #348
Open
@Scarsz Scarsz mentioned this pull request Jun 7, 2021
Open
Vankka and others added 16 commits June 8, 2021 02:25
@Vankka Vankka linked an issue Jul 1, 2021 that may be closed by this pull request
Linking doesn't re-establish the connection to database in case of loss #1175
Open
Vankka added a commit that referenced this pull request Jul 9, 2021
@Vankka
Add ApiManager changes from #1150
d9ab698
@Scarsz Scarsz mentioned this pull request Aug 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vankka Vankka Vankka requested changes

Assignees

@Scarsz Scarsz

Labels
enhancement in progress needs documentation needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linking doesn't re-establish the connection to database in case of loss Link account via slash commands
3 participants
@Scarsz @Vankka @granny