nonreactive examples for hooks were not compilable as written

[rogusdev]

My code was out of date, so I missed b6d3da2 -- but I still caught one more, and added an example. Also tweaked the comments.

[rogusdev]

Notably: for the example, I did not call &*res.read_unchecked() as the docs suggest on https://dioxuslabs.com/learn/0.5/reference/use_resource -- instead choosing to simply do res(), which definitely works. If the longer syntax is preferred / recommended, I would like to update my example to keep best practices in all places, but I'd also like to hear why, thanks.

[ealmloff]

This is a really good use case for ReadOnlySignal<i32>. We automatically convert T to ReadOnlySignal<T> in the props so it will work out of the box with the router and it will be reactive without the extra use_reactive hook

[ealmloff]

use_reactive is good for non-reactive state that is created in the middle of a component like this:

let state = use_signal(|| 0);
let doubled = state() * 2;
use_effect(use_reactive((&doubled,), |(doubled,)| println!("Manually manipulate the dom")));

[rogusdev]

Ok, that makes sense, however 2 questions then:

1. Is that distinction documented somewhere? After this PR gets merged (in some form), I already intend to update https://dioxuslabs.com/learn/0.5/reference/use_resource with a link to the example and an explanation
2. If it is already done with props, so should it happen with the #[component] approach as well? As in, should this just work without the use_reactive or explicit ReadOnlySignal at all? -- Oh wait, or do you mean if I mark ReadOnlySignal<T> in the component args, I just don't have to wrap it with ReadOnlySignal when passing in?

[ealmloff]

1. Is that distinction documented somewhere? After this PR gets merged (in some form), I already intend to update https://dioxuslabs.com/learn/0.5/reference/use_resource with a link to the example and an explanation

Not yet 🙂

2. If it is already done with props, so should it happen with the #[component] approach as well? As in, should this just work without the use_reactive or explicit ReadOnlySignal at all?

The conversion happens when you use the component if you explicitly use ReadOnlySignal<T> in your props or #[component].

// Because value is a signal, it is reactive and any reads will automatically add the signal as a dependency to use_effect, use_resource, etc
#[component]
fn Comp(value: ReadOnlySignal<i32>) -> Element {None}

Comp {
   // A new signal is created here
   value: 0
}

[rogusdev]

I will update the example, and also add documentation around this.