Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code functionality to exit gently on signal handlers. #98

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

prasanna-ds
Copy link

Overview of the PR:

  • Added signal handlers to the asyncio event loop.
  • Update config on receiving the signal, stop the pyrogram client, stop the event loop and eventually close the event loop.
  • Added an integration test to receive a signal from a thread to see that event loops have been stopped successfully.

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #98 (277797b) into master (b42861f) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   98.72%   98.83%   +0.10%     
==========================================
  Files           5        5              
  Lines         157      171      +14     
==========================================
+ Hits          155      169      +14     
  Misses          2        2              
Impacted Files Coverage Δ
media_downloader.py 98.41% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b42861f...277797b. Read the comment docs.

@Dineshkarthik Dineshkarthik self-requested a review May 19, 2021 20:21
This was linked to issues May 19, 2021
@stale
Copy link

stale bot commented Jul 7, 2021

This issue has been automatically marked as stale because it has not had recent activity in the past 60 days. It will be closed if no further activity occurs in the next 7 days. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 7, 2021
@Dineshkarthik Dineshkarthik added enhancement New feature or request and removed wontfix This will not be worked on labels Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update last item scraped more often Gentle Exit
2 participants