Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple chat downloads and autorefresh #235

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Hugeldugelking
Copy link

@Hugeldugelking Hugeldugelking commented May 20, 2022

The script is now able to download media from multiple chats and scan the chats again after a given interval. For this, the config.yaml needed some modifications. Tests were also updated for the modified downloader script.

fixes: #77

Hugeldugelking added 2 commits May 20, 2022 15:45
enh: added possibility to scan for new media after a given interval
@Dineshkarthik
Copy link
Owner

@Hugeldugelking please check the Pylint errors. More details can be found here

@Dineshkarthik Dineshkarthik self-requested a review May 20, 2022 14:02
@Dineshkarthik Dineshkarthik added the enhancement New feature or request label May 20, 2022
@Hugeldugelking
Copy link
Author

@Dineshkarthik I don't get no pylint errors anymore. Sorry, it's my first time working on an open project with such tools :)

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #235 (e7f3ed9) into master (92fb58a) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   98.93%   99.06%   +0.13%     
==========================================
  Files           6        6              
  Lines         187      213      +26     
==========================================
+ Hits          185      211      +26     
  Misses          2        2              
Impacted Files Coverage Δ
media_downloader.py 98.64% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92fb58a...e7f3ed9. Read the comment docs.

@Dineshkarthik
Copy link
Owner

@Hugeldugelking is the auto_refresh optional or mandatory? I don't want to make this application something like long-pooling/continuous running one, it should be a stateful (last read message ids) single run and the users can add it to cron if they want to run this on regular intervals.

@Hugeldugelking
Copy link
Author

@Dineshkarthik auto_refresh is optional. If set to 0 the script will only run once. I did this because I want to try to put this script in a docker container to run it on an unraid server for example. Your Idea with cron is great and I will take a look at it.
Should auto_refresh remain optional in the application? Otherwise I'd remove this from the code.
Regarding the failing checks: This has nothing to do with my modification, does it?

@ofifoto
Copy link

ofifoto commented Jun 10, 2022

bump :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

add multi chat_id downloads
3 participants