Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: FW-1060 post translation #1178

Merged
merged 6 commits into from
May 18, 2024
Merged

feat: FW-1060 post translation #1178

merged 6 commits into from
May 18, 2024

Conversation

dudu0506
Copy link
Contributor

https://mask.atlassian.net/browse/FW-1060

Pull Request

Description

Related Issue

Closes FW-0000

Checklist

  • I have tested these changes locally.
  • I have reviewed the code changes.
  • I have added unit tests if applicable.

@vercel Vercel
Copy link

vercel bot commented May 16, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firefly-mask-social ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 7:44am

nuanyang233
nuanyang233 reviewed May 16, 2024
View reviewed changes
src/helpers/getBrowserLanguage.ts Outdated Show resolved Hide resolved
src/helpers/getLangNameFromLocal.ts Outdated Show resolved Hide resolved
@dudu0506 dudu0506 requested a review from nuanyang233 May 16, 2024 10:02
@dudu0506 dudu0506 requested a review from guanbinrui May 17, 2024 01:42
@dudu0506 dudu0506 requested a review from guanbinrui May 17, 2024 06:25
@guanbinrui
refactor: code style (#1181)
835169c 
* refactor: code style

* refactor: mv Language
@guanbinrui guanbinrui merged commit c221e00 into main May 18, 2024
9 checks passed
@guanbinrui guanbinrui deleted the feat/post-translate branch May 18, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guanbinrui guanbinrui guanbinrui approved these changes

@nuanyang233 nuanyang233 Awaiting requested review from nuanyang233

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dudu0506 @nuanyang233 @guanbinrui @InvalidBoy