Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pick prs overwritten #1024

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: pick prs overwritten #1024

wants to merge 3 commits into from

Conversation

Jack-Works
Copy link
Member

pick back #972 and #1001 which seems like accidentally overwritten by #985 cc @guanbinrui
fw-0000

@Jack-Works Jack-Works requested a review from guanbinrui May 8, 2024 04:59
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firefly-mask-social ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 5:12am

@guanbinrui
Copy link
Member

As @UncleBill reported, this patch led to OOM.

@Jack-Works
Copy link
Member Author

can you give more details? cc @UncleBill

@swkatmask
Copy link
Contributor

can you give more details? cc @UncleBill

Sorry, I can't. It just seems that the CI crash due to OOM more often after this patch.

@Jack-Works
Copy link
Member Author

can you give more details? cc @UncleBill

I added this:

export NODE_OPTIONS=--max_old_space_size=4098, if that's not enough, maybe it can even bigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants