refactor: change how to represent modal routes #11628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanbinrui
pushed a commit
that referenced
this pull request
May 24, 2024
* refactor: change how to represent modal routes (#11628) * refactor: update routes of popup (#11630) * refactor: defer loading of routed modals (#11632) * refactor: change pnpm config (#11633) * refactor: support x.com in code (#11634) * chore: update to pnpm 9 (#11635) * chore: update to react 19 (#11636) * fix: cf build (#11637) * fix: splint crashes * fix: react-qrcode-logo crashes * feat: add react compiler (#11638) * fix: react-devtools * fix: source map * chore: update to eslint 9 (#11641) * refactor: enable rule react/naming-convention/component-name * refactor: enable rule typescript-eslint/no-non-null-asserted-optional-chain * refactor: enable rule react/no-children-* * refactor: enable rule no-async-promise-executor no-promise-executor-return and @typescript-eslint/return-await * chore: eslint --------- Co-authored-by: Jack Works <5390719+Jack-Works@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mf-0000
before:
/modal/modal-namewith hidden state{ mainLocation: '/backing-router' }now:
/backing-router?modal=encode('/modal-name')I expect this does not break anything. This change is for the React Router data router