Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: introduce concept of current user as my* #11512

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

refactor: introduce concept of current user as my* #11512

wants to merge 2 commits into from

Conversation

swkatmask
Copy link
Contributor

@swkatmask swkatmask commented Mar 22, 2024 •
edited

My* Stuff

MyIdentity would be more accurate and clearer than LastRecognizedIdentity

MF-0000 FW-0000

@swkatmask swkatmask added this to the 2.25.0 milestone Mar 22, 2024
@swkatmask swkatmask force-pushed the refactor/me-concept branch 2 times, most recently from a0eae87 to 8b3a2ac Compare March 22, 2024 02:15
@guanbinrui
Copy link
Member

This concept is widely used, and I don't believe it's necessary to change it at this time.

Jack-Works
Jack-Works requested changes Mar 23, 2024
View reviewed changes
Copy link
Member

@Jack-Works Jack-Works left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to rename LastRecognizedIdentity to something else. But "MyIdentity" may look inappropriate, the new name should reflect that it is collected from the current site, not our database (like currentPersonaIdentifier)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jack-Works Jack-Works Jack-Works requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.25.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@swkatmask @guanbinrui @Jack-Works