Skip to content

Commit

Permalink
feat: add eth_maxPriorityFeePerGas
Browse files Browse the repository at this point in the history
  • Loading branch information
Jack-Works committed May 13, 2024
1 parent c79a0d0 commit f2ca61e
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 12 deletions.
14 changes: 7 additions & 7 deletions packages/mask/entry-sdk/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ The list is built from what [MetaMask supported](https://docs.metamask.io/wallet
- [x] eth_call
- [x] eth_chainId
- eth_coinbase: not supported by infura
- [ ] eth_createAccessList: not in MetaMask
- eth_createAccessList: not in MetaMask
- [x] eth_estimateGas
- [x] eth_feeHistory
- [x] eth_gasPrice
Expand All @@ -34,7 +34,7 @@ The list is built from what [MetaMask supported](https://docs.metamask.io/wallet
- [x] eth_getTransactionReceipt
- [x] eth_getUncleCountByBlockHash
- [x] eth_getUncleCountByBlockNumber
- [ ] eth_maxPriorityFeePerGas: not in MetaMask but in their docs <https://docs.metamask.io/wallet/reference/eth_maxpriorityfeepergas/>
- [x] eth_maxPriorityFeePerGas
- [x] eth_syncing

### Filters
Expand All @@ -50,12 +50,12 @@ The list is built from what [MetaMask supported](https://docs.metamask.io/wallet

This section excludes PoW era methods and methods listed in <https://ethereum.github.io/execution-apis/api-documentation/>.

- [ ] eth_protocolVersion
- [ ] net_listening
- [ ] net_peerCount
- eth_protocolVersion: not in MetaMask
- net_listening: not in MetaMask
- net_peerCount: not in MetaMask
- [x] net_version
- [ ] web3_clientVersion
- [ ] web3_sha3
- web3_clientVersion: not in MetaMask
- web3_sha3: not in MetaMask

### [EIP-758: Subscriptions and filters for completed transactions](https://eips.ethereum.org/EIPS/eip-758)

Expand Down
9 changes: 5 additions & 4 deletions packages/web3-shared/evm/src/helpers/isReadonlyMethodType.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { EthereumMethodType } from '../types/index.js'

export const readonlyMethodType = [
EthereumMethodType.net_version,
EthereumMethodType.eth_blockNumber,
EthereumMethodType.eth_blobBaseFee,
EthereumMethodType.eth_blockNumber,
EthereumMethodType.eth_call,
EthereumMethodType.eth_estimateGas,
EthereumMethodType.eth_feeHistory,
Expand All @@ -15,7 +14,7 @@ export const readonlyMethodType = [
EthereumMethodType.eth_getBlockTransactionCountByHash,
EthereumMethodType.eth_getBlockTransactionCountByNumber,
EthereumMethodType.eth_getCode,
EthereumMethodType.eth_getFilterChanges,
EthereumMethodType.eth_getFilterChanges, // is it really readonly?
EthereumMethodType.eth_getLogs,
EthereumMethodType.eth_getProof,
EthereumMethodType.eth_getStorageAt,
Expand All @@ -26,8 +25,10 @@ export const readonlyMethodType = [
EthereumMethodType.eth_getTransactionReceipt,
EthereumMethodType.eth_getUncleCountByBlockHash,
EthereumMethodType.eth_getUncleCountByBlockNumber,
EthereumMethodType.eth_newPendingTransactionFilter,
EthereumMethodType.eth_maxPriorityFeePerGas,
EthereumMethodType.eth_newPendingTransactionFilter, // is it really readonly?
EthereumMethodType.eth_syncing,
EthereumMethodType.net_version,
] as const
Object.freeze(readonlyMethodType)
export function isReadonlyMethodType(type: EthereumMethodType) {
Expand Down
3 changes: 2 additions & 1 deletion packages/web3-shared/evm/src/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -222,12 +222,13 @@ export enum EthereumMethodType {
eth_getTransactionReceipt = 'eth_getTransactionReceipt',
eth_getUncleCountByBlockHash = 'eth_getUncleCountByBlockHash',
eth_getUncleCountByBlockNumber = 'eth_getUncleCountByBlockNumber',
eth_maxPriorityFeePerGas = 'eth_maxPriorityFeePerGas',
eth_sendRawTransaction = 'eth_sendRawTransaction',
eth_sendTransaction = 'eth_sendTransaction',
eth_sign = 'eth_sign',
eth_signTransaction = 'eth_signTransaction',
eth_signTypedData_v4 = 'eth_signTypedData_v4',
eth_supportedChainIds = 'eth_supportedChainIds', // ??
eth_supportedChainIds = 'eth_supportedChainIds', // unknown EIP
eth_syncing = 'eth_syncing',
personal_sign = 'personal_sign',
// Filters
Expand Down

0 comments on commit f2ca61e

Please sign in to comment.